-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove md4 and related ENABLE_BLAKE2B_HASHING feature flag #36054
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @Anas12091101! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
71e1c54
to
5abfb6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, we can merge after the DEPR is accepted coordinating with anyone that we need to coordinate with.
5abfb6b
to
cdf1b5c
Compare
I don't think "chore" is the right commit prefix for a change like this. How about "refactor!" -- the exclamation mark indicates a breaking change, but otherwise this doesn't change any functionality. |
cdf1b5c
to
4c9e5a8
Compare
4c9e5a8
to
0de7569
Compare
Description
This PR removes md4 and related ENABLE_BLAKE2B_HASHING feature flag
Useful information to include:
Supporting information
#36024
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None"
Other information
Include anything else that will help reviewers and consumers understand the change.